Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: less flaky test_synthetic_size_while_deleting #7622

Merged
merged 1 commit into from
May 6, 2024

Conversation

koivunej
Copy link
Contributor

@koivunej koivunej commented May 6, 2024

#7585 introduced test case for deletions while synthetic size is being calculated. The test has a race against deletion, but we only accept one outcome. Fix it to accept 404 as well, as we cannot control from outside which outcome happens.

Evidence: https://neon-github-public-dev.s3.amazonaws.com/reports/pr-7456/8970595458/index.html#/testresult/32a5b2f8c4094bdb

@koivunej koivunej enabled auto-merge (squash) May 6, 2024 15:08
@koivunej koivunej disabled auto-merge May 6, 2024 15:19
@koivunej
Copy link
Contributor Author

koivunej commented May 6, 2024

Disabled auto-merge while searching if we need an additional allowed_error, but the 404 is logged at INFO, so no need.

@koivunej koivunej enabled auto-merge (squash) May 6, 2024 15:20
Copy link

github-actions bot commented May 6, 2024

2904 tests run: 2783 passed, 0 failed, 121 skipped (full report)


Flaky tests (3)

Postgres 16

  • test_delete_tenant_exercise_crash_safety_failpoints[real_s3-timeline-delete-before-index-deleted-at-False-Check.RETRY_WITHOUT_RESTART]: release
  • test_vm_bit_clear_on_heap_lock: debug

Postgres 15

  • test_gc_aggressive: debug

Code coverage* (full report)

  • functions: 31.4% (6237 of 19864 functions)
  • lines: 47.1% (46732 of 99252 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
152f1f1 at 2024-05-06T16:00:17.103Z :recycle:

@koivunej koivunej merged commit a96e15c into main May 6, 2024
53 checks passed
@koivunej koivunej deleted the joonas/less_flaky_synthetic_size_while_deleting branch May 6, 2024 15:52
conradludgate pushed a commit that referenced this pull request May 8, 2024
#7585 introduced test case for deletions while synthetic size is being
calculated. The test has a race against deletion, but we only accept one
outcome. Fix it to accept 404 as well, as we cannot control from outside
which outcome happens.

Evidence:
https://neon-github-public-dev.s3.amazonaws.com/reports/pr-7456/8970595458/index.html#/testresult/32a5b2f8c4094bdb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants