Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(neon_test_utils): restrict installation to superuser #7624

Merged
merged 1 commit into from
May 8, 2024

Conversation

skyzh
Copy link
Member

@skyzh skyzh commented May 6, 2024

Problem

The test utils should only be used during tests. Users should not be able to create this extension on their own. Create this pull request to see if anything breaks if we only allow installation by superuser.

Summary of changes

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • Do we need to implement analytics? if so did you add the relevant metrics to the dashboard?
  • If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section.

Checklist before merging

  • Do not forget to reformat commit message to not include the above checklist

Signed-off-by: Alex Chi Z <chi@neon.tech>
@skyzh skyzh requested a review from a team as a code owner May 6, 2024 18:12
@skyzh skyzh requested a review from lubennikovaav May 6, 2024 18:12
Copy link

github-actions bot commented May 6, 2024

2886 tests run: 2759 passed, 0 failed, 127 skipped (full report)


Flaky tests (1)

Postgres 15

  • test_gc_aggressive: debug

Code coverage* (full report)

  • functions: 31.4% (6242 of 19882 functions)
  • lines: 47.1% (46745 of 99299 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
8cf875e at 2024-05-06T18:54:47.175Z :recycle:

@skyzh skyzh requested a review from hlinnaka May 6, 2024 18:57
@skyzh skyzh merged commit 1173ee6 into main May 8, 2024
53 checks passed
@skyzh skyzh deleted the skyzh/limit-neon-test-utils branch May 8, 2024 15:53
skyzh added a commit that referenced this pull request May 9, 2024
a-masterov pushed a commit that referenced this pull request May 20, 2024
The test utils should only be used during tests. Users should not be
able to create this extension on their own.

Signed-off-by: Alex Chi Z <chi@neon.tech>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants