Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proxy: cull http connections #7632

Merged
merged 7 commits into from
May 7, 2024
Merged

proxy: cull http connections #7632

merged 7 commits into from
May 7, 2024

Conversation

conradludgate
Copy link
Contributor

@conradludgate conradludgate commented May 7, 2024

Problem

Some HTTP client connections can stay open for quite a long time.

Summary of changes

When there are too many HTTP client connections, pick a random connection and gracefully cancel it.

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • Do we need to implement analytics? if so did you add the relevant metrics to the dashboard?
  • If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section.

Checklist before merging

  • Do not forget to reformat commit message to not include the above checklist

Copy link

github-actions bot commented May 7, 2024

2970 tests run: 2843 passed, 0 failed, 127 skipped (full report)


Flaky tests (4)

Postgres 15

  • test_partial_evict_tenant[relative_equal]: release
  • test_gc_aggressive: debug
  • test_lock_time_tracing: release

Postgres 14

  • test_empty_branch_remote_storage_upload: debug

Code coverage* (full report)

  • functions: 31.2% (6246 of 19995 functions)
  • lines: 46.7% (46770 of 100184 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
50a45e9 at 2024-05-07T16:52:56.158Z :recycle:

@conradludgate conradludgate marked this pull request as ready for review May 7, 2024 15:59
@conradludgate conradludgate requested a review from a team as a code owner May 7, 2024 15:59
@conradludgate conradludgate requested a review from khanova May 7, 2024 15:59
@conradludgate conradludgate merged commit 0c99e5e into main May 7, 2024
53 checks passed
@conradludgate conradludgate deleted the proxy-cull-http branch May 7, 2024 17:15
conradludgate added a commit that referenced this pull request May 8, 2024
## Problem

Some HTTP client connections can stay open for quite a long time.

## Summary of changes

When there are too many HTTP client connections, pick a random
connection and gracefully cancel it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants