neon_local init: write pageserver.toml directly; no pageserver --init --config-override
#7638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…side of `neon_local init` The `NeonCli.init()` persists the non-default pageserver config values for remote storage & `NeonEnvBuilder.pageserver_config_override` in `pageserver.toml`. We don't need to repeat them on each pageserver start after that.
…blame/test-suite-narrow-pageserver-config-override
Rewrite the pageserver.toml instead.
…--pageserver-config-override`
This allows inlining append_pageserver_param_overrides into NeonCli.init()
…ng init, not start
…age during init, not start" This reverts commit 511f593.
…into problame/remove-pageserver-config-overrides
…akes a toml tempfile
…into problame/remove-pageserver-config-overrides
…into problame/remove-pageserver-config-overrides
Conflicts:
control_plane/src/pageserver.rs
=> pick ours
…into problame/remove-pageserver-config-overrides
…erver-config-overrides
The test_forward_compatibility test runs the old production binaries, but is supposed to always run the latest neon_local binary. I think commit 6acbee2 broke that by accident because in that commit, from_repo_dir is introduced and runs an `init_start()` before the `test_forward_compatibility` gets a chance to patch up the neon_local_binpath.
…r --init --config-override`
…ame/neon-local-init-dont-use-config-override
problame
changed the title
pageserver.toml directly; no pageserver --init --config-overrideneon_local init: write pageserver.toml directly; no pageserver --init --config-override
skyzh
approved these changes
May 7, 2024
Base automatically changed from
problame/remove-pageserver-config-overrides
to
main
May 7, 2024 16:30
VladLazar
approved these changes
May 7, 2024
3096 tests run: 2963 passed, 0 failed, 133 skipped (full report)Flaky tests (5)Postgres 16
Postgres 15
Postgres 14Code coverage* (full report)
* collected from Rust tests only The comment gets automatically updated with the latest test results
bf2af40 at 2024-05-08T09:11:33.913Z :recycle: |
a-masterov
pushed a commit
that referenced
this pull request
May 20, 2024
…-init --config-override` (#7638) This does to `neon_local` what neondatabase/aws#1322 does to our production deployment. After both are merged, there are no users of `pageserver --init` / `pageserver --config-override` left, and we can remove those flags eventually.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does to
neon_localwhat https://github.com/neondatabase/aws/pull/1322 does to our production deployment.After both are merged, there are no users of
pageserver --init/pageserver --config-overrideleft, and we can remove those flags eventually.