Fix flaky test_gc_of_remote_layers #7647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3024 tests run: 2891 passed, 0 failed, 133 skipped (full report)Code coverage* (full report)
* collected from Rust tests only The comment gets automatically updated with the latest test results
a044870 at 2024-05-08T15:29:48.050Z :recycle: |
koivunej
reviewed
May 8, 2024
koivunej
approved these changes
May 8, 2024
There was a problem hiding this comment.
I think your conclusion is correct, but I'd still like to get rid of the extra tenant which has no business causing problems like this (many tests have this pattern sadly).
Confirmed there's the
assert not env.pageserver.log_contains("Nothing to GC")
Which was probably quite obvious from failures.
petuhovskiy
changed the title
a-masterov
pushed a commit
that referenced
this pull request
May 20, 2024
Fixes flaky test `test_gc_of_remote_layers`, which was failing because of the `Nothing to GC` pageserver log. I looked into the fails, it seems that backround `gc_loop` sometimes started GC for initial tenant, which wasn't configured to disable GC. The fix is to not create initial tenant with enabled gc at all. Fixes #7538
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes flaky test
test_gc_of_remote_layers, which was failing because of theNothing to GCpageserver log.I looked into the fails, it seems that backround
gc_loopsometimes started GC for initial tenant, which wasn'tconfigured to disable GC. The fix is to not create initial tenant with enabled gc at all.
Fixes #7538