Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tiered compaction: add order asserts after delta key k-merge #7648

Merged
merged 1 commit into from
May 8, 2024

Conversation

arpad-m
Copy link
Member

@arpad-m arpad-m commented May 8, 2024

Adds ordering asserts to the output of the delta key iterator MergeDeltaKeys that implements a k-merge.

Part of #7296 : the asserts added by this PR get hit in the reproducers of #7296 as well, but they are earlier in the pipeline.

@arpad-m arpad-m marked this pull request as ready for review May 8, 2024 01:19
@arpad-m arpad-m requested a review from a team as a code owner May 8, 2024 01:19
@arpad-m arpad-m requested a review from arssher May 8, 2024 01:19
@arpad-m arpad-m requested review from problame and removed request for arssher May 8, 2024 01:27
Copy link

github-actions bot commented May 8, 2024

3024 tests run: 2891 passed, 0 failed, 133 skipped (full report)


Flaky tests (1)

Postgres 16

  • test_vm_bit_clear_on_heap_lock: debug

Code coverage* (full report)

  • functions: 31.2% (6257 of 20054 functions)
  • lines: 46.7% (46938 of 100592 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
a3e222d at 2024-05-08T02:02:09.423Z :recycle:

@arpad-m arpad-m merged commit b6d547c into main May 8, 2024
52 of 53 checks passed
@arpad-m arpad-m deleted the arpad/compaction_delta_order_asserts branch May 8, 2024 11:22
a-masterov pushed a commit that referenced this pull request May 20, 2024
Adds ordering asserts to the output of the delta key iterator
`MergeDeltaKeys` that implements a k-merge.

Part of #7296 : the asserts added by this PR get hit in the reproducers
of #7296 as well, but they are earlier in the pipeline.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants