Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

openapi: resolve the synthetic_size duplication #7651

Merged
merged 2 commits into from
May 10, 2024

Conversation

koivunej
Copy link
Contributor

@koivunej koivunej commented May 8, 2024

We had accidentally left two endpoints for tenant: /synthetic_size and /size. Size had the more extensive description but has returned 404 since renaming. Remove the /size in favor of the working one and describe the text/html output.

@koivunej koivunej requested a review from a team as a code owner May 8, 2024 07:40
@koivunej koivunej requested a review from VladLazar May 8, 2024 07:40
Copy link

github-actions bot commented May 8, 2024

3024 tests run: 2891 passed, 0 failed, 133 skipped (full report)


Flaky tests (3)

Postgres 16

  • test_gc_aggressive: release
  • test_vm_bit_clear_on_heap_lock: debug

Postgres 15

  • test_pageserver_small_inmemory_layers[True]: debug

Code coverage* (full report)

  • functions: 31.6% (6336 of 20063 functions)
  • lines: 47.4% (47660 of 100645 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
6aa1323 at 2024-05-08T12:50:44.318Z :recycle:

Copy link
Contributor

@VladLazar VladLazar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once this merges it would be good to update the cloud swagger spec and auto-generated client as well. Running make gogenerate in the cloud repo with the updated swagger did the trick last time (see https://github.com/neondatabase/cloud/pull/12340)

pageserver/src/http/openapi_spec.yml Show resolved Hide resolved
pageserver/src/http/openapi_spec.yml Show resolved Hide resolved
@koivunej
Copy link
Contributor Author

koivunej commented May 8, 2024

Running make gogenerate in the cloud repo with the updated swagger did the trick last time (see neondatabase/cloud#12340)

I'll do it (or have someone do it) once I get the #7650 haggled (this week).

@duskpoet could you actually give this a quick round of review since I think you added the original /synthetic_size description but I forgot to tag you in? If you are delayed, I might merge this in but we'll still need to make sure the javascript rendering the SVG will not be broken by this change. Alternatively you can just reply if you know there's an automatic test against this openapi.yaml and where can I see it fail.

@duskpoet
Copy link
Member

duskpoet commented May 9, 2024

hey! nothing has changed in the structure, so I don't see how anything can break

if iam reading the diff correctly

@koivunej
Copy link
Contributor Author

hey! nothing has changed in the structure, so I don't see how anything can break

if iam reading the diff correctly

Nothing in the JSON or SVG output changed, but the openapi description changed.

@koivunej koivunej merged commit 86905c1 into main May 10, 2024
53 checks passed
@koivunej koivunej deleted the joonas/openapi_synthetic_size branch May 10, 2024 14:15
a-masterov pushed a commit that referenced this pull request May 20, 2024
We had accidentally left two endpoints for `tenant`: `/synthetic_size`
and `/size`. Size had the more extensive description but has returned
404 since renaming. Remove the `/size` in favor of the working one and
describe the `text/html` output.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants