-
Notifications
You must be signed in to change notification settings - Fork 360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
openapi: resolve the synthetic_size duplication #7651
Conversation
3024 tests run: 2891 passed, 0 failed, 133 skipped (full report)Code coverage* (full report)
* collected from Rust tests only The comment gets automatically updated with the latest test results
6aa1323 at 2024-05-08T12:50:44.318Z :recycle: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once this merges it would be good to update the cloud swagger spec and auto-generated client as well. Running make gogenerate
in the cloud repo with the updated swagger did the trick last time (see https://github.com/neondatabase/cloud/pull/12340)
I'll do it (or have someone do it) once I get the #7650 haggled (this week). @duskpoet could you actually give this a quick round of review since I think you added the original |
hey! nothing has changed in the structure, so I don't see how anything can break if iam reading the diff correctly |
Nothing in the JSON or SVG output changed, but the openapi description changed. |
We had accidentally left two endpoints for `tenant`: `/synthetic_size` and `/size`. Size had the more extensive description but has returned 404 since renaming. Remove the `/size` in favor of the working one and describe the `text/html` output.
We had accidentally left two endpoints for
tenant
:/synthetic_size
and/size
. Size had the more extensive description but has returned 404 since renaming. Remove the/size
in favor of the working one and describe thetext/html
output.