Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proxy: do not invalidate cache for permit errors #7652

Merged
merged 1 commit into from
May 8, 2024

Conversation

conradludgate
Copy link
Contributor

Problem

If a permit cannot be acquired to connect to compute, the cache is invalidated. This had the observed affect of sending more traffic to ProxyWakeCompute on cplane.

Summary of changes

Make sure that permit acquire failures are marked as "should not invalidate cache".

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • Do we need to implement analytics? if so did you add the relevant metrics to the dashboard?
  • If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section.

Checklist before merging

  • Do not forget to reformat commit message to not include the above checklist

@conradludgate conradludgate requested a review from a team as a code owner May 8, 2024 09:58
@conradludgate conradludgate requested a review from khanova May 8, 2024 09:58
Copy link

@stradig stradig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@conradludgate conradludgate enabled auto-merge (squash) May 8, 2024 10:14
@conradludgate conradludgate merged commit e3a2631 into main May 8, 2024
48 checks passed
@conradludgate conradludgate deleted the proxy-fix-permit-errors branch May 8, 2024 10:33
Copy link

github-actions bot commented May 8, 2024

3024 tests run: 2891 passed, 0 failed, 133 skipped (full report)


Code coverage* (full report)

  • functions: 31.2% (6257 of 20059 functions)
  • lines: 46.7% (46939 of 100613 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
74d7a9a at 2024-05-08T10:41:30.990Z :recycle:

a-masterov pushed a commit that referenced this pull request May 20, 2024
## Problem

If a permit cannot be acquired to connect to compute, the cache is
invalidated. This had the observed affect of sending more traffic to
ProxyWakeCompute on cplane.

## Summary of changes

Make sure that permit acquire failures are marked as "should not
invalidate cache".
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants