draw_timeline_dir: draw branch points and gc cutoff lines #7657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in addition to layer names, expand the input vocabulary to recognize
lines in the form of:
${kind}:${lsn}
which is, kind in gc_cutoff or branch. Lsn is accepted in Lsn display
format (x/y) or hex (as used in layer names).
gc_cutoff and branch have different colors.
3048 tests run: 2915 passed, 0 failed, 133 skipped (full report)Flaky tests (2)Postgres 16
Postgres 15
Code coverage* (full report)
* collected from Rust tests only The comment gets automatically updated with the latest test results
79795ed at 2024-05-08T15:53:10.739Z :recycle: |
petuhovskiy
approved these changes
May 8, 2024
|
There are (too) many examples on this thread: https://neondb.slack.com/archives/C06UEMLK7FE/p1714028169884359 (spot checking), most of them though only have min and max branch points (green). |
a-masterov
pushed a commit
that referenced
this pull request
May 20, 2024
in addition to layer names, expand the input vocabulary to recognize
lines in the form of:
${kind}:${lsn}
where:
- kind in `gc_cutoff` or `branch`
- lsn is accepted in Lsn display format (x/y) or hex (as used in layer
names)
gc_cutoff and branch have different colors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in addition to layer names, expand the input vocabulary to recognize lines in the form of:
where:
gc_cutofforbranchgc_cutoff and branch have different colors.