Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix checkpoint metric #7701

Merged
merged 2 commits into from
May 10, 2024
Merged

Conversation

lubennikovaav
Copy link
Contributor

@lubennikovaav lubennikovaav commented May 10, 2024

Split checkpoint_stats into two separate metrics: checkpoints_req and checkpoints_timed

Fixes commit 21e1a49

Split checkpoint_stats into two separate metrics: checkpoints_req and checkpoints_timed
Copy link
Contributor

@Bodobolero Bodobolero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, pls correct the typo in the help

vm-image-spec.yaml Outdated Show resolved Hide resolved
Copy link

github-actions bot commented May 10, 2024

3024 tests run: 2891 passed, 0 failed, 133 skipped (full report)


Code coverage* (full report)

  • functions: 31.4% (6322 of 20142 functions)
  • lines: 47.3% (47652 of 100829 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
60799ee at 2024-05-10T16:28:33.133Z :recycle:

Co-authored-by: Peter Bendel <peterbendel@neon.tech>
@lubennikovaav lubennikovaav enabled auto-merge (squash) May 10, 2024 15:43
@lubennikovaav lubennikovaav merged commit 95098c3 into main May 10, 2024
49 checks passed
@lubennikovaav lubennikovaav deleted the fix_sql_exporter_checkpoint_metric branch May 10, 2024 16:20
a-masterov pushed a commit that referenced this pull request May 20, 2024
Split checkpoint_stats into two separate metrics: checkpoints_req and
checkpoints_timed

Fixes commit
21e1a49

---------

Co-authored-by: Peter Bendel <peterbendel@neon.tech>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants