Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore!: always use async walredo, warn if sync is configured #7754

Merged
merged 3 commits into from
May 15, 2024

Conversation

problame
Copy link
Contributor

refs #7753

This PR is step (1) of removing sync walredo from Pageserver.

Changes:

  • Remove the sync impl
  • If sync is configured, warn! and use async instead
  • Remove the metric that exposes kind
  • Remove the tenant status API that exposes kind

Future Work

After we've released this change to prod and are sure we won't
roll back, we will

  1. update the prod Ansible to remove the config flag from the prod
    pageserver.toml.
  2. remove the remaining kind code in pageserver

These two changes need no release inbetween.

See #7753 for details.

refs #7753

This PR is step (1) of removing sync walredo from Pageserver.

Changes:
* Remove the sync impl
* If sync is configured, warn! and use async instead
* Remove the metric that exposes `kind`
* Remove the tenant status API that exposes `kind`

Future Work
-----------

After we've released this change to prod and are sure we won't
roll back, we will

1. update the prod Ansible to remove the config flag from the prod
   pageserver.toml.
2. remove the remaining `kind` code in pageserver

These two changes need no release inbetween.

See  #7753 for details.
@problame problame requested a review from a team as a code owner May 14, 2024 13:52
@problame problame requested review from arpad-m and jcsp and removed request for arpad-m May 14, 2024 13:52
@problame
Copy link
Contributor Author

@jcsp please double-check the plan laid out in #7753 for rollback-safety.

problame added a commit that referenced this pull request May 14, 2024
refs #7753

Preceding PR #7754
laid out the plan, this one wraps it up.
Copy link

github-actions bot commented May 15, 2024

3048 tests run: 2921 passed, 0 failed, 127 skipped (full report)


Code coverage* (full report)

  • functions: 31.5% (6349 of 20177 functions)
  • lines: 47.4% (47957 of 101088 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
47504fb at 2024-05-15T11:31:56.748Z :recycle:

@problame problame merged commit c3dd646 into main May 15, 2024
55 checks passed
@problame problame deleted the problame/async-walredo/remove-sync-impl-part-1 branch May 15, 2024 13:04
a-masterov pushed a commit that referenced this pull request May 20, 2024
refs #7753

This PR is step (1) of removing sync walredo from Pageserver.

Changes:
* Remove the sync impl
* If sync is configured, warn! and use async instead
* Remove the metric that exposes `kind`
* Remove the tenant status API that exposes `kind`

Future Work
-----------

After we've released this change to prod and are sure we won't
roll back, we will

1. update the prod Ansible to remove the config flag from the prod
   pageserver.toml.
2. remove the remaining `kind` code in pageserver

These two changes need no release inbetween.

See  #7753 for details.
problame added a commit that referenced this pull request Jun 5, 2024
refs #7753

Preceding PR #7754
laid out the plan, this one wraps it up.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants