Add dummy lsn lease http and page service APIs #7815

arpad-m · 2024-05-20T22:06:53Z

We want to introduce a concept of temporary and expiring LSN leases. This adds both a http API as well as one for the page service to obtain temporary LSN leases.

This adds a dummy implementation to unblock integration work of this API. A functional implementation of the lease feature is deferred to a later step.

Fixes #7808

github-actions · 2024-05-20T22:55:32Z

3096 tests run: 2969 passed, 0 failed, 127 skipped (full report)

Flaky tests (3)

Postgres 16

test_crafted_wal_end[last_wal_record_xlog_switch]: debug

Postgres 14

test_crafted_wal_end[wal_record_crossing_segment_followed_by_small_one]: debug
test_timeline_deletion_with_files_stuck_in_upload_queue: debug

Code coverage* (full report)

functions: 31.3% (6414 of 20474 functions)
lines: 48.0% (49312 of 102742 lines)

* collected from Rust tests only

_{The comment gets automatically updated with the latest test results
62b9583 at 2024-05-21T20:20:11.776Z :recycle:}

pageserver/src/page_service.rs

libs/pageserver_api/src/models.rs

pageserver/src/page_service.rs

pageserver/src/http/routes.rs

koivunej

Smaller nits. I think adding documentation when adding stuff to our models.rs "stuff holder" would help make sense of that file without understanding all of the other code.

pageserver/src/tenant/timeline.rs

Co-authored-by: Joonas Koivunen <joonas@neon.tech>

pageserver/src/http/openapi_spec.yml

In the process_query function in page_service.rs there was some redundant duplication. Remove it and create a vector of whitespace separated parts at the start and then use `slice::strip_prefix`. Only use `starts_with` in the places with multiple whitespace separated parameters: here we want to preserve grep/rg ability. Followup of #7815, requested in #7815 (review)

arpad-m added 2 commits May 20, 2024 23:35

Add dummy make_lsn_lease function to timeline

9a06295

Add a http handler for it as well

0f4cfcf

arpad-m requested review from jcsp and koivunej May 20, 2024 22:06

arpad-m requested a review from a team as a code owner May 20, 2024 22:06

arpad-m changed the title ~~Add empty lsn API~~ Add empty lsn lease API to pageserver page service and http May 20, 2024

arpad-m changed the title ~~Add empty lsn lease API to pageserver page service and http~~ Add dummy lsn lease http and page service APIs May 20, 2024

jcsp reviewed May 21, 2024

View reviewed changes

pageserver/src/page_service.rs Show resolved Hide resolved