Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip unnecessary shared state updates in safekeepers #7851

Merged
merged 1 commit into from
May 23, 2024

Conversation

petuhovskiy
Copy link
Member

I looked at the metrics from #7768 on staging and it seems that manager does too many iterations. This is probably caused by background job remove_wal.rs which iterates over all timelines and tries to remove WAL and persist control file. This causes shared state updates and wakes up the manager. The fix is to skip notifying about the updates if nothing was updated.

@petuhovskiy petuhovskiy requested a review from a team as a code owner May 22, 2024 23:02
@petuhovskiy petuhovskiy requested a review from arssher May 22, 2024 23:02
Copy link

3108 tests run: 2981 passed, 0 failed, 127 skipped (full report)


Code coverage* (full report)

  • functions: 31.4% (6449 of 20544 functions)
  • lines: 48.3% (49860 of 103260 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
d2a2bb6 at 2024-05-22T23:50:06.813Z :recycle:

@petuhovskiy petuhovskiy merged commit 8f3c316 into main May 23, 2024
63 of 64 checks passed
@petuhovskiy petuhovskiy deleted the fix-sk-maybe-persist branch May 23, 2024 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants