safekeeper: remove .partial suffix on the last WAL file. #7882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arssher
force-pushed
the
sk-rm-partial
branch
2 times, most recently
from
f7f4bb1
to
f06f67c
Compare
3162 tests run: 3029 passed, 0 failed, 133 skipped (full report)Code coverage* (full report)
* collected from Rust tests only The comment gets automatically updated with the latest test results
0a43b05 at 2024-05-27T14:11:22.819Z :recycle: |
Reasons: - it makes pg_waldump usage slightly more cumbersome, forcing to rename file. - it makes pull_timeline slightly more cumbersome because at any moment source file can be renamed from partial to full. Leave ability to read .partial files for backward compatibility.
3 tasks
petuhovskiy
reviewed
May 31, 2024
There was a problem hiding this comment.
Risky change, it changes on-disk storage format. I support the change, but we need to be very careful when releasing it.
AFAIU it's not forward compatible, because previous version of safekeepers will complain if they'll see unfinished file without .partial prefix, right? It's strange that test_forward_compatibility passes then.
It conflicts with #7887 in a few lines, will look at this PR again after 7887 merges.
truncate_wal does full -> .partial rename, most likely that's the explanation |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reasons:
Leave ability to read .partial files for backward compatibility.
Fixes #4459