Fix sinonjs#492 by upgrading formatio and setting a limit

neonstalwart · Jul 30, 2014 · 15a7e8e · 15a7e8e
1 parent 93b6338
commit 15a7e8e
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 2 deletions.
diff --git a/lib/sinon.js b/lib/sinon.js
@@ -363,7 +363,10 @@ var sinon = (function (formatio) {
     }
 
     if (formatio) {
-        var formatter = formatio.configure({ quoteStrings: false });
+        var formatter = formatio.configure({
+                quoteStrings: false,
+                limitChildrenCount: 250
+            });
         sinon.format = function () {
             return formatter.ascii.apply(formatter, arguments);
         };

diff --git a/package.json b/package.json
@@ -22,7 +22,7 @@
     "prepublish": "./build"
   },
   "dependencies": {
-    "formatio": "~1.0",
+    "formatio": "~1.1.1",
     "util": ">=0.10.3 <1"
   },
   "devDependencies": {

diff --git a/test/sinon_test.js b/test/sinon_test.js
@@ -563,6 +563,13 @@ buster.testCase("sinon", {
             assert.equals(sinon.format({ id: 42 }), "{ id: 42 }");
         },
 
+        "// should configure formatio to use maximum 250 entries" : function(){
+            // not sure how we can verify this integration with the current setup
+            // where sinon.js calls formatio as part of it's loading
+            // extracting sinon.format into a separate module would make this a lot
+            // easier
+        },
+
         "formats strings without quotes": function () {
             assert.equals(sinon.format("Hey"), "Hey");
         }