Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include Pull Request #36 #37

Closed
anorstrom opened this issue Oct 4, 2018 · 7 comments
Closed

Include Pull Request #36 #37

anorstrom opened this issue Oct 4, 2018 · 7 comments

Comments

@anorstrom
Copy link

Hi,
I think the closed Pull Request #36 made by @Ikke should be merged and included in the release.
Tested the changes, and when running the Microsoft Centered UI experience, these changes fix issues in the TOTP enrollment pages.

Besides that 2.2.0.39 worked nicely!

Kind Regards,
Andreas

@redhook62
Copy link
Member

Thanks

@redhook62
Copy link
Member

Missed !

@redhook62
Copy link
Member

New Version 40

@anorstrom
Copy link
Author

Tested the new version 40 and white space is now added to the first page in the TOTP enrollment, so that looks nicer when running MS Centered UI.
However, the rest of the pages in the TOTP enrollment does not have that white space. Could these be fixed too in the same way?

@redhook62
Copy link
Member

@anorstrom

Yes, of course it's possible to modify the pages of the wizard.
You will soon have a new build. this night.

However, it's important for us that the default theme remains also perfectly functional.
And, the theme of Microsoft (in alpha) begins to impact the standard.
You will be able to post issues to "MS Centered UI", because from this point of view it's their problem (CSS).

I think, my very, very old friends from Microsoft will be able to answer you. Yes, you do it before...
Indicate to them that the "mercato" is finished, it would be desirable to target a version 1.0 for production by next spring :)

The current version, will come out of the beta phase. Next week the documentation will be updated.
We will quickly follow on, the biometric authentication WebAuthN which is very promising (https://fido2.azurewebsites.net)

Best Regards

@redhook62
Copy link
Member

New Version 2.2.0.41

@anorstrom
Copy link
Author

@anorstrom

Yes, of course it's possible to modify the pages of the wizard.
You will soon have a new build. this night.

However, it's important for us that the default theme remains also perfectly functional.
And, the theme of Microsoft (in alpha) begins to impact the standard.
You will be able to post issues to "MS Centered UI", because from this point of view it's their problem (CSS).

I think, my very, very old friends from Microsoft will be able to answer you. Yes, you do it before...
Indicate to them that the "mercato" is finished, it would be desirable to target a version 1.0 for production by next spring :)

The current version, will come out of the beta phase. Next week the documentation will be updated.
We will quickly follow on, the biometric authentication WebAuthN which is very promising (https://fido2.azurewebsites.net)

Best Regards

Yes understand, important to support default theme of course. I tried to open a few tickets at the MS repo, but they do not respond very fast ;). Thank you for fixing this! Tested version 41, and it looks nice now in the Centered UI.

Would be really nice if you could get FIDO2 support into this solution! Looking forward to test that :)

Thank you,
Andreas

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants