Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Site export contains disabled nodes #118

Closed
bwaidelich opened this issue Nov 19, 2021 · 3 comments
Closed

Site export contains disabled nodes #118

bwaidelich opened this issue Nov 19, 2021 · 3 comments
Assignees

Comments

@bwaidelich
Copy link
Member

Since #57 the Neos.Demo Sites.xml export contains 5 disabled (aka "hidden") document nodes:

<variant sortingIndex="1250" workspace="live" nodeType="Neos.Demo:Document.NotFoundPage" version="1" removed="" hidden="1" hiddenInIndex="1">
<dimensions>
<language>de</language>
</dimensions>
<accessRoles __type="array"/>
<creationDateTime __type="object" __classname="DateTime">2019-03-22T17:37:13+00:00</creationDateTime>
<lastModificationDateTime __type="object" __classname="DateTime">2019-03-22T17:37:13+00:00</lastModificationDateTime>
<properties>
<uriPathSegment __type="string">notfound</uriPathSegment>
<metaRobotsNoindex __type="boolean">1</metaRobotsNoindex>
<title __type="string">Not Found</title>
</properties>
</variant>
<variant sortingIndex="1350" workspace="live" nodeType="Neos.Demo:Document.NotFoundPage" version="1" removed="" hidden="1" hiddenInIndex="1">
<dimensions>
<language>lv</language>
</dimensions>
<accessRoles __type="array"/>
<creationDateTime __type="object" __classname="DateTime">2019-03-22T17:37:13+00:00</creationDateTime>
<lastModificationDateTime __type="object" __classname="DateTime">2019-03-22T17:37:13+00:00</lastModificationDateTime>
<properties>
<uriPathSegment __type="string">notfound</uriPathSegment>
<metaRobotsNoindex __type="boolean">1</metaRobotsNoindex>
<title __type="string">Not Found</title>
</properties>
</variant>
<variant sortingIndex="1450" workspace="live" nodeType="Neos.Demo:Document.NotFoundPage" version="1" removed="" hidden="1" hiddenInIndex="1">
<dimensions>
<language>da</language>
</dimensions>
<accessRoles __type="array"/>
<creationDateTime __type="object" __classname="DateTime">2019-03-22T17:37:13+00:00</creationDateTime>
<lastModificationDateTime __type="object" __classname="DateTime">2019-03-22T17:37:13+00:00</lastModificationDateTime>
<properties>
<uriPathSegment __type="string">notfound</uriPathSegment>
<metaRobotsNoindex __type="boolean">1</metaRobotsNoindex>
<title __type="string">Not Found</title>
</properties>
</variant>
<variant sortingIndex="1150" workspace="live" nodeType="Neos.Demo:Document.NotFoundPage" version="1" removed="" hidden="1" hiddenInIndex="1">
<dimensions>
<language>nl</language>
</dimensions>
<accessRoles __type="array"/>
<creationDateTime __type="object" __classname="DateTime">2019-03-22T17:37:13+00:00</creationDateTime>
<lastModificationDateTime __type="object" __classname="DateTime">2019-03-22T17:37:13+00:00</lastModificationDateTime>
<properties>
<uriPathSegment __type="string">notfound</uriPathSegment>
<metaRobotsNoindex __type="boolean">1</metaRobotsNoindex>
<title __type="string">Not Found</title>
</properties>
</variant>
<variant sortingIndex="1050" workspace="live" nodeType="Neos.Demo:Document.NotFoundPage" version="1" removed="" hidden="1" hiddenInIndex="1">

I doubt this was done on purpose, but I might be missing something. @mficzel maybe you can recall?

@mficzel
Copy link
Member

mficzel commented Nov 19, 2021

That was surely not on purpose. Probably just me beeing clumsy.

@mficzel mficzel self-assigned this Apr 1, 2022
@mficzel
Copy link
Member

mficzel commented Apr 1, 2022

@bwaidelich those hidden nodes are the "Neos.Demo:Document.NotFoundPage" in non default dimension. As we are currently rendering the 404 in the default dimension i would consider this correct as they are autocreated as children of root.

@bwaidelich
Copy link
Member Author

Ah I see, thanks for the explanation!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants