Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Definition of "lastVersion" for packages #409

Closed
Sebobo opened this issue Sep 13, 2021 · 2 comments · Fixed by #440
Closed

Definition of "lastVersion" for packages #409

Sebobo opened this issue Sep 13, 2021 · 2 comments · Fixed by #440
Assignees
@Sebobo
Labels
marketplace Related to the package listing / search question
Projects
Marketing Task Board

Comments

@Sebobo
Copy link
Member

Sebobo commented Sep 13, 2021

Realised today that the lastVersion of a package is not the one with the highest
version number, but the one that was last published.

This leads to lower versions of packages appearing in the results which might not match
the search criterias of the user (f.e. compatible Neos version).

We have to discuss what we expect and what we have to adjust if we change the definition.
@regniets
Copy link
Contributor

I would expect the "highest" released final version (non beta, dev etc) as on packagist: https://packagist.org/packages/neos/neos

@regniets
Copy link
Contributor

Should be easy to fix right here:
https://github.com/neos/Neos.NeosIo/blob/master/DistributionPackages/Neos.MarketPlace/Classes/Service/PackageVersion.php#L51

@kdambekalns kdambekalns added the marketplace Related to the package listing / search label Dec 16, 2021
@Sebobo Sebobo self-assigned this Jul 18, 2022
@Sebobo Sebobo added this to In progress in Marketing Task Board Jul 18, 2022
Sebobo added a commit to Sebobo/Neos.NeosIo that referenced this issue Jul 18, 2022
@Sebobo
BUGFIX: Prevent lower version from appearing as package search result
7046c01 
By defining the highest package version as „lastVersion“ we prevent f.e.
that a later release version 5.0.2 is shown as result instead of a 8.0.2 which was released 2 minutes earlier.

Resolves: neos#409
@Sebobo Sebobo mentioned this issue Jul 18, 2022
Merged
Marketing Task Board automation moved this from In progress to Done Jul 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Sebobo Sebobo

Labels
marketplace Related to the package listing / search question
Projects
Marketing Task Board
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

BUGFIX: Prevent lower version from appearing as package search result Sebobo/Neos.NeosIo
3 participants
@kdambekalns @Sebobo @regniets