Refactoring of CaseStudies/Showcases and Service Provider Listing #362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
regniets
commented
Oct 1, 2020
•
regniets
commented
- Moved CaseStudies/References to separate package (named it "CaseStudies" as "References" or "Cases" could be misleading. CaseStudies is pretty clear, though)
- Changed ServiceProviderlisting to show badges and provide a grid view.
- Added CaseStudies based on preact
Named package "CaseStudies" as this is less ambiguous than "References"
ServiceOfferings can now display a grid view and show badges. This was necessary to build a similar view for casestudies.
added correct sorting arrows place sorting above filtering, feels more natural
Put in some (not type-safe) translations. Should do for now, though could be handled more elegant
- Added separate handling for grids and tables - Mobile view, also for Service Providers
|
Great change, thx! As I said during the call, moving the logo and badge in the list view would be good and making it need less vertical space per item. The grid view should be default IMO and maybe we don't show the logo there as it hurts the visual flow. |
Resolves: #360
Sebobo
approved these changes
Oct 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.