-
-
Notifications
You must be signed in to change notification settings - Fork 186
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
Jenkins
committed
May 4, 2020
1 parent
14f834f
commit 8884133
Showing
1 changed file
with
73 additions
and
0 deletions.
There are no files selected for viewing
73 changes: 73 additions & 0 deletions
73
Documentation/TheDefinitiveGuide/PartV/ChangeLogs/5024.rst
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,73 @@ | ||
`5.0.24 (2020-05-04) <https://github.com/neos/flow-development-collection/releases/tag/5.0.24>`_ | ||
================================================================================================ | ||
|
||
Overview of merged pull requests | ||
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | ||
|
||
`BUGFIX: Make sure to use only a consistent NumbersReaderCache <https://github.com/neos/flow-development-collection/pull/1991>`_ | ||
-------------------------------------------------------------------------------------------------------------------------------- | ||
|
||
It might happen that there is a discrepancy between parsedFormatsIndices and parsedFormats cache. We need to make sure we are accessing the consistent information instead of relying that both are there, to avoid a PHP exception. | ||
|
||
Same fix was already applied to DatesReader, see https://github.com/neos/flow-development-collection/pull/1899. | ||
|
||
Resolves #564 | ||
|
||
**Checklist** | ||
|
||
- [ ] Code follows the PSR-2 coding style | ||
- [ ] Tests have been created, run and adjusted as needed | ||
- [ ] The PR is created against the [lowest maintained branch](https://www.neos.io/features/release-roadmap.html) | ||
|
||
* Packages: ``Flow`` | ||
|
||
`BUGFIX: Make sure to use only a consistent DatesReaderCache <https://github.com/neos/flow-development-collection/pull/1899>`_ | ||
------------------------------------------------------------------------------------------------------------------------------ | ||
|
||
It might happen that there is a discrepancy between parsedFormatsIndices and parsedFormats cache. We need to make sure we are accessing the consistent information instead of relying that both are there, to avoid a PHP exception. | ||
|
||
Resolves #564 | ||
|
||
The problem described in #564 is not easy to reproduce, as it only happens "once in a while" in production. See issue comments for further information. | ||
|
||
**Checklist** | ||
|
||
- [x] Code follows the PSR-2 coding style | ||
- [ ] Tests have been created, run and adjusted as needed | ||
- [x] The PR is created against the [lowest maintained branch](https://www.neos.io/features/release-roadmap.html) | ||
|
||
* Packages: ``Flow`` | ||
|
||
`BUGFIX: Fix error handling for importing resources <https://github.com/neos/flow-development-collection/pull/1888>`_ | ||
--------------------------------------------------------------------------------------------------------------------- | ||
|
||
<!-- | ||
Thanks for your contribution, we appreciate it! | ||
|
||
Please read through our pull request guidelines, there are some interesting things there: | ||
https://discuss.neos.io/t/creating-a-pull-request/506 | ||
|
||
And one more thing... Don't forget about the tests! | ||
--> | ||
|
||
While working with `ResourceManager` I noticed that importing non-existent resources would fail later in the process than expected: They would only fail when trying to copy the temporary file to it's persistent location instead of failing when fetching the original file. | ||
|
||
**What I did** | ||
This PR fixes the incorrect error handling of fetching files when importing resources. | ||
|
||
**How I did it** | ||
The code assumed that `copy` would throw an exception if it failed - however, it returns `false` in that case. | ||
|
||
**How to verify it** | ||
Try to import a non-existent resource (e.g. http://example.com/this-file-does-not-exist). It should now correctly throw the `Could not copy the file from "..." to temporary file "..."` exception from `WritableFileSystemStorage::importResource` instead of the much later `The temporary file of the file import could not be moved to the final target "..."` from `WritableFileSystemStorage::moveTemporaryFileToFinalDestination` | ||
|
||
**Checklist** | ||
|
||
- [x] Code follows the PSR-2 coding style | ||
- [ ] Tests have been created, run and adjusted as needed | ||
- [x] The PR is created against the [lowest maintained branch](https://www.neos.io/features/release-roadmap.html) | ||
|
||
* Packages: ``Flow`` | ||
|
||
`Detailed log <https://github.com/neos/flow-development-collection/compare/5.0.23...5.0.24>`_ | ||
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ |