Merge pull request #3277 from mhsdesign/task/fixIntegerConverterWhenC…

…onvertingDateTime TASK: Ensure `IntegerConverter` converts DateTime to unix time stamp as int
neos · Jan 25, 2024 · c0b8578 · c0b8578
2 parents 306a13c + c70601a
commit c0b8578
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/Neos.Flow/Classes/Property/TypeConverter/IntegerConverter.php b/Neos.Flow/Classes/Property/TypeConverter/IntegerConverter.php
@@ -55,7 +55,7 @@ class IntegerConverter extends AbstractTypeConverter
     public function convertFrom($source, $targetType, array $convertedChildProperties = [], PropertyMappingConfigurationInterface $configuration = null)
     {
         if ($source instanceof \DateTimeInterface) {
-            return $source->format('U');
+            return (int)$source->format('U');
         }
 
         if ($source === null || $source === '') {

diff --git a/Neos.Flow/Tests/Unit/Property/TypeConverter/IntegerConverterTest.php b/Neos.Flow/Tests/Unit/Property/TypeConverter/IntegerConverterTest.php
@@ -57,7 +57,7 @@ public function convertFromCastsStringToInteger()
     public function convertFromCastsDateTimeToInteger()
     {
         $dateTime = new \DateTime();
-        self::assertSame($dateTime->format('U'), $this->converter->convertFrom($dateTime, 'integer'));
+        self::assertSame((int)$dateTime->format('U'), $this->converter->convertFrom($dateTime, 'integer'));
     }
 
     /**