Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust release scripts to keep self.version in manifests #3186

Closed
kdambekalns opened this issue Sep 28, 2023 · 5 comments
Closed

Adjust release scripts to keep self.version in manifests #3186

kdambekalns opened this issue Sep 28, 2023 · 5 comments

Comments

@kdambekalns
Copy link
Member

Ah, the release scripts… I did not think of those. 🤦‍♂️

Originally posted by @kdambekalns in #3035 (comment)

@ahaeslich
Copy link
Member

ahaeslich commented Oct 5, 2023

Staring down the rabbit hole and wondering how this will impact our next releases (especially the upcomming major). And I have questions 😇.

My observations and questions:

First of all: the releases published after #3035 was merged also changed the dependencies in neos/eel, neos/fluid-adaptor and neos/kickstarter.

While the removal of self.version happend inside neos/flow one package (neos/utility-pdo) was never marked as such in the first place. Was this intentional?

Looking into neos-development-collection I can see the same changes comming up there since the release after introducing self.version. What is confusing is, that in many places we are using either the death star or a version constraint. Was the original intention for all packages maintained inside flow-development-collection or neos-development-collection to use self.version for dependency declaration between each other? Or should there be some exceptions?

@kitsunet
Copy link
Member

kitsunet commented Oct 9, 2023

I think we should do self.version for everything otherwise it probably doesn't belong in the collection in the first place, which might be the case for some of the utility packages. Pretty sure there is no need to update utility-pdo but for now, I would say no exceptions, if it#s in the collection it gets self-version.

@kitsunet
Copy link
Member

kitsunet commented Oct 9, 2023

@kdambekalns looking at the scripts, I guess easiest would be to just scrap the whole set-dependencies.sh and change nothing in there? Or what was your plan...

@kdambekalns
Copy link
Member Author

Well, I think we can get rid of anything that now sues self.version. If that leaves the script(s) empty, we can drop them, if not, they should at least be smaller.

kitsunet added a commit to kitsunet/flow-development-distribution that referenced this issue Oct 30, 2023
Only adjust Distribution dependnecies and external packages.

Fixes: neos/flow-development-collection#3186
kitsunet added a commit to kitsunet/neos-development-distribution that referenced this issue Oct 30, 2023
Only adjust Distribution dependnecies and external packages.

Fixes: neos/flow-development-collection#3186
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants