BUGFIX: The ScalarTypeToObjectConverter should expose boolean instead of bool #1087
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertlemke
changed the title
|
This commit was already merged to master, here's the 4.0 and up version. |
albe
approved these changes
Sep 22, 2017
|
Merging this now, since it's already in master |
3 tasks
ComiR
pushed a commit
to ComiR/flow-development-collection
that referenced
this pull request
Aug 17, 2018
BUGFIX: The ScalarTypeToObjectConverter should expose boolean instead of bool
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Fixed the ScalarTypeToObjectConverter to expose boolean as supported sourceType instead of bool
How I did it
Used the keyboard
How to verify it
The TypeConverter now works for boolean values
Checklist