Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUGFIX: Restore XLIFF translation fallback #1094

Merged
merged 2 commits into from Nov 11, 2017
Merged

BUGFIX: Restore XLIFF translation fallback #1094

merged 2 commits into from Nov 11, 2017

Commits on Oct 20, 2017

  1. BUGFIX: Restore XLIFF translation fallback 

    This modification fixes the translation fallback mechanism and the ability to read regionalized language variants.

Issues fixed:

* Translation fallback did not work. `Neos.Flow.i18n.fallbackRule.order` was ignored when looking for XLIFF files
* When using a regional `Neos.Flow.i18n.defaultLocale` (e.g. `de_AT` for an Austrian version of German `de`), XLIFF files were never read from  a directory with the full `defaultLocale` name, but only from the base language directory. In the example, files in `Packages/Application/Vendor.Package/Resources/Private/Translations/de_AT` were never read, only `Packages/Application/Vendor.Package/Resources/Private/Translations/de`.
    @fritjofbohm
    fritjofbohm committed Oct 20, 2017
    Configuration menu
    Copy the full SHA
    f9c49f7 View commit details
    Browse the repository at this point in the history

  2. BUGFIX: Restore XLIFF translation fallback: Use canonical string cast… 

    … and add comment

* `$locale` is now cast the way it is in `\Neos\Flow\I18n\Service`
* Added a small comment why the locale chain is reversed
    @fritjofbohm
    fritjofbohm committed Oct 20, 2017
    Configuration menu
    Copy the full SHA
    2f0a48c View commit details
    Browse the repository at this point in the history