New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
!!!TASK: Require PHP 7.1 #1160
Merged
Merged
!!!TASK: Require PHP 7.1 #1160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This raises the PHP version requirement for framework packages to PHP 7.1 to be able to use a bunch of useful features for us in the future. Eg. iterable pseudo type, nullable types, void returns and more.
Travis configuration was updated to only test 7.1 and 7.2 now. |
kdambekalns
approved these changes
Dec 30, 2017
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❤️
bwaidelich
reviewed
Jan 2, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't forget to adjust the docs, too. They state the minimal required PHP version IIRC
daniellienert
approved these changes
Jan 4, 2018
kdambekalns
added a commit
to kdambekalns/neos-development-collection
that referenced
this pull request
Jan 9, 2018
As of neos/flow-development-collection#1160 Flow requires PHP 7.1 or higher. The master of Neos needs to follow, so this adjusts the Travis CI build matrix to skip PHP 7.0. Additionally it removes some options no longer needed, since the required PostgreSQL versions are meanwhile available without any use of sudo in the default container infrastructure, as shown in - https://docs.travis-ci.com/user/reference/overview/#Virtualization-environments - https://docs.travis-ci.com/user/database-setup/#Using-a-different-PostgreSQL-Version
ComiR
pushed a commit
to ComiR/flow-development-collection
that referenced
this pull request
Aug 17, 2018
!!!TASK: Require PHP 7.1 This raises the PHP version requirement for framework packages to PHP 7.1 to be able to use a bunch of useful features for us in the future. Eg. iterable pseudo type, nullable types, void returns and more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This raises the PHP version requirement for framework packages to
PHP 7.1 to be able to use a bunch of useful features for us in the
future.
Eg. iterable pseudo type, nullable types, void returns and more.