!!! TASK: Make ObjectManagerInterface a superset of PSR-11 #1176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Makes the ``ObjectManagerInterface`` fully compatible with the PSR-11 ``ContainerInterface``. This is a breaking change in case you implemented ``ObjectManagerInterface`` because you would have to implement the ``has`` method now in your implementation.
albe
approved these changes
Jan 12, 2018
|
Nope, no drawbacks AFAIK. We might want to look at how we can (in appropriate places) say we want the Containerinterface and get the object manager. But that can be done later. |
ComiR
pushed a commit
to ComiR/flow-development-collection
that referenced
this pull request
Aug 17, 2018
…ce-psr-13 !!! TASK: Make ObjectManagerInterface a superset of PSR-11 Makes the ``ObjectManagerInterface`` fully compatible with the PSR-11 ``ContainerInterface``. This is a breaking change in case you implemented ``ObjectManagerInterface`` because you would have to implement the ``has`` method now in your implementation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes the
ObjectManagerInterfacefully compatible withthe PSR-11
ContainerInterface.This is a breaking change in case you implemented
ObjectManagerInterfacebecause you would have to implement thehasmethod now in your implementation.