BUGFIX: Detect checked state for bound object collections #1230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a collection property with obejcts is bound to a checkbox VH, this change makes sure to check object identifiers against the passed value when automatically determining the `checked` state. Fixes neos#1229
|
as a bugfix shouldn't this target a lower branch? |
|
Absolutely, just didn't select the correct branch… |
|
Ah, there is Travis… |
aertmann
reviewed
Mar 7, 2018
|
Looks good, but yeah, a test would be cool |
|
@kdambekalns the lowest supported branch is 3.3 - did you not target this on purpose? |
bwaidelich
reviewed
Apr 19, 2018
| @@ -89,7 +93,22 @@ public function render($checked = null, $multiple = null) | |||
| } | |||
| if (is_array($propertyValue)) { | |||
| if ($checked === null) { | |||
| $checked = in_array($valueAttribute, $propertyValue, true); | |||
| if (TypeHandling::isSimpleType(TypeHandling::getTypeForValue(current($propertyValue))) === false || Arrays::containsMultipleTypes($propertyValue)) { | |||
There was a problem hiding this comment.
I think we can just change this to always walk through the array. Arrays::containsMultipleTypes() iterates through it anyways.
|
@kdambekalns sorry, I messed with Git.. |
|
Regarding 3.3… well, I was just too lazy, AFAIR |
kdambekalns
force-pushed
the
bugfix/1229-checked-with-objects
branch
from
d51f567
to
5f4d4ce
Compare
bwaidelich
approved these changes
Apr 19, 2018
|
I think 4.0 as target is fine! |
albe
approved these changes
Apr 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a collection property with objects is bound to a checkbox VH,
this change makes sure to check object identifiers against the passed
value when automatically determining the
checkedstate.Fixes #1229