Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEATURE: base64 en-/decoding via Fusion #1327

Merged
merged 3 commits into from Aug 20, 2018
Merged

Conversation

lhortmann
Copy link
Contributor

What I did
An Eel-Helper which uses PHP functions to encode and decode a data-string

@kitsunet
Copy link
Member

Hey Lisa, thanks, this is indeed a great idea, I would probably avoid creating a separate class for this though and just add the functionality to the string helper.
What do you think?

@bwaidelich
Copy link
Member

Nice one! I agree to Christian's comment. Let's add it to the existing StringHelper and call it base64encode()/base64decode()

@lhortmann
Copy link
Contributor Author

It's okay for me, too. But I hadn't found any time to change and adjust it ;-) Hope I'll find time on the weekend!

@kdambekalns kdambekalns changed the title Create Base64Helper FEATURE: Create Base64Helper Jun 25, 2018
Copy link
Member

@albe albe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ping - this is nice and easy enough to land in 5.1

@bwaidelich
Copy link
Member

I'll take care

@bwaidelich bwaidelich self-assigned this Aug 20, 2018
@bwaidelich bwaidelich changed the title FEATURE: Create Base64Helper FEATURE: base64 en-/decoding via Fusion Aug 20, 2018
@kitsunet
Copy link
Member

Will merge when travis is done.

@kitsunet kitsunet merged commit 68e8485 into neos:master Aug 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants