Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUGFIX: Properly escape sub process variables on windows #182

Merged
merged 1 commit into from Dec 15, 2015
Merged

BUGFIX: Properly escape sub process variables on windows #182

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 2 additions & 1 deletion TYPO3.Flow/Classes/TYPO3/Flow/Core/Booting/Scripts.php
View file
Open in desktop
Expand Up @@ -622,7 +622,8 @@ public static function buildPhpCommand(array $settings)
if (DIRECTORY_SEPARATOR === '/') {
$command .= sprintf('%s=%s ', $argumentKey, escapeshellarg($argumentValue));
} else {
$command .= sprintf('SET %s=%s&', $argumentKey, escapeshellarg($argumentValue));
// SET does not parse out quotes, hence we need escapeshellcmd here instead
$command .= sprintf('SET %s=%s&', $argumentKey, escapeshellcmd($argumentValue));
}
}
if (DIRECTORY_SEPARATOR === '/') {
Expand Down