Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TASK: Fix variable naming in AuthenticationTokenResolver #1940

Merged
merged 1 commit into from Mar 20, 2020
Merged

TASK: Fix variable naming in AuthenticationTokenResolver #1940

merged 1 commit into from Mar 20, 2020

Conversation

albe
Copy link
Member

@albe albe commented Mar 18, 2020

Some small follow-up fixes to #1936

@albe albe mentioned this pull request Mar 18, 2020
Merged
@albe albe requested a review from kitsunet March 18, 2020 14:39
kitsunet
kitsunet approved these changes Mar 18, 2020
View reviewed changes
Copy link
Member

@kitsunet kitsunet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! That makes way more sense now :D

@albe
Copy link
Member Author

albe commented Mar 20, 2020

Test failure:

1) Neos\Flow\Tests\Functional\Security\Authentication\Provider\PersistedUsernamePasswordProviderTest::successfulAuthentication
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'2020-03-18T15:45:21+01:00'
+'2020-03-18T15:45:20+01:00'

and psalm, which will be fixed with upmerges I'll do later today. Gonna merge this.

@albe albe merged commit d615e00 into master Mar 20, 2020
@albe albe deleted the albe-fix-tokenresolver branch March 20, 2020 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kitsunet kitsunet kitsunet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@albe @kitsunet