BUGFIX: Adapt virtual objects change to factory arguments bugfix #1989
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Psalm errors will be resolved with #1966 |
bwaidelich
approved these changes
Apr 21, 2020
There was a problem hiding this comment.
I don't really see all implications and can't test this right now, but this makes a lot of sense to me and I would just trust @albe here :)
|
tbqh I trust the tests more :D Things are more green than before, so 🎉 |
github-actions
bot
force-pushed
the
albe-factory-arguments
branch
from
0876732
to
7e10108
Compare
|
Correction: Fully green now 💚 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original code only attempted to fix newly introduced factory arguments, but since #1967 those factory arguments are separated from object arguments. Hence this "fix" didn't work any more.