Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUGFIX: Resolve type in UniqueEntityValidator #220

Merged
merged 1 commit into from Jan 25, 2016
Merged

BUGFIX: Resolve type in UniqueEntityValidator #220

merged 1 commit into from Jan 25, 2016

Conversation

astehlik
Copy link
Contributor

Run the given validator value through TypeHandling::getTypeForValue()
to make sure doctrine proxies are resolved to the actual domain
model type.

Resolves: FLOW-433

Run the given validator value through TypeHandling::getTypeForValue()
to make sure doctrine proxies are resolved to the actual domain
model type.

Resolves: NEOS-1764
@daniellienert
Copy link
Member

@astehlik Thanks for that patch - also fixes my issue!
👍 by reading and testing.

The bug also exists in older versions. Would you please reopen the pull request for the oldest supported version where the bug exists - which is 2.3 so it could be upmerged

@astehlik
Copy link
Contributor Author

This pull request ist for the 2.3 branch, I hope this is OK. Please let me know if I should change anything.

@bwaidelich
Copy link
Member

👍 by reading - this should also solve FLOW-433

@daniellienert
Copy link
Member

@bwaidelich I moved the ticket from Neos to Flow, so NEOS-1764 actually was FLOW-433.

daniellienert added a commit that referenced this pull request Jan 25, 2016
BUGFIX: Resolve type in UniqueEntityValidator
@daniellienert daniellienert merged commit a767d1b into neos:2.3 Jan 25, 2016
@bwaidelich
Copy link
Member

@daniellienert awesome, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants