BUGFIX: Persist doctrine MetadataStorage changes immediately

[bwaidelich]

This basically adds a EntityManager::flush() call after MetadataStorage::ensureInitialized()
invocations in order to apply any metadata migrations immediately.

Without this a ./flow doctrine:migrate call might leave the metadata storage in a half-migrated
state if it leads to an exception.

Related: #2244
Related: #2357

[kitsunet]

Sooo weird that it's necessary but well, if that's what is needed....

[kdambekalns]

If it helps… 🤔

[kdambekalns]

I am really at a loss here… Why? I tried PHP errors in migrations, invalid SQL in migrations, re-applying already executed migrations – and did not need that (again).

But, whatever, if it solves if, do it. 🤷‍♂️

This doesn't do anything like that, too: https://github.com/doctrine/migrations/blob/3.0.x/lib/Doctrine/Migrations/Tools/Console/Command/MigrateCommand.php

[bwaidelich]

@kdambekalns Mh, you're right (as usual).. And I can't reproduce this any longer..
What I tried:

UPDATE flow_doctrine_migrationstatus SET version = RIGHT(version, 14);
ALTER TABLE flow_doctrine_migrationstatus DROP executed_at, DROP execution_time;

(to revert the metadata table to its old state)

DELETE FROM flow_doctrine_migrationstatus WHERE version = '20200908155620';

to remove the migration that was missing in my case.

Previously that led to a swallowed error and the half-migrated table.
Now (without this PR applied) I get an exception

An exception occurred while executing 'ALTER TABLE neos_flow_resourcemanagement_persistentresource DROP md5':

SQLSTATE[42000]: Syntax error or access violation: 1091 Can't DROP COLUMN `md5`; check that it exists

(as expected)

and the table is fully migrated..

Probably I was in some weird state when I tried it last.

I'll close this one for now and hope that this heisenbug never returns :)

[kdambekalns]

I'll close this one for now and hope that this heisenbug never returns :)

🤞

[kdambekalns]

Wait, we never merged this…

[albe]

I thought that was because the issue that this seemed to solve was no longer reproducible without this change?

Now (without this PR applied) I get an exception
(as expected)
and the table is fully migrated..

[kdambekalns]

@albe Yes, but see #2357 …

[albe]

🤔 well, yeah. If this fixes those cases...

PS: Would like to create bugfix releases tomorrow or so, so should we merge this before?