BUGFIX: Update tagFormats to match defined severities #273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Uses the severities descriped in \TYPO3\Flow\Log\LoggerInterface
kdambekalns
changed the title
|
I'd like to see |
|
Info is included? |
|
Sorry, I meant |
|
Hmm.. As such I have no problem with adding And if I look at: |
|
That's what you get from purely reading a change: I just saw something that was there, was now gone. If it can never end up there, that obviously doesn't matter at all. 👍 after reading the related code as well. Still, that looks like a bugfix and should even go into 2.3… |
kdambekalns
changed the title
|
looks good 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses the severities descriped in \TYPO3\Flow\Log\LoggerInterface