TASK: Modernize Doctrine array types

[kdambekalns]

Update the code of JsonArrayType and ObjectArray to follow modern PHP practices.

Checklist

• Code follows the PSR-2 coding style
• Tests have been created, run and adjusted as needed
• The PR is created against the lowest maintained branch
• Reviewer - PR Title is brief but complete and starts with FEATURE|TASK|BUGFIX
• Reviewer - The first section explains the change briefly for change-logs
• Reviewer - Breaking Changes are marked wit !!! and have upgrade-instructions

[kdambekalns]

Doctrine\DBAL\Platforms\PostgreSQL94Platform depends on class or interface doctrine\dbal\platforms\postgresqlplatform that does not exist

That psalm error is a) not reproducible locally and b) nonsense. And because of a) I cannot even do a baseline update to "fix" it. 🤷‍♂️

[mhsdesign]

Looks good by reading so far

[kitsunet]

Merging after tests are done.

[mhsdesign]

The use of private results in a regression:

➜  neos-manufacture-highest git:(8.3) ✗ ./flow site:import Neos.Demo   
This command can use a lot of memory when importing sites with many resources.
If the import is successful, you will see a message saying "Import of site ... finished".
If you do not see this message, the import failed, most likely due to insufficient memory.
Increase the memory_limit configuration parameter of your php CLI to attempt to fix this.
Starting import...
---
Cannot access private constant Neos\Flow\Persistence\Doctrine\DataTypes\JsonArrayType::FLOW_JSON_ARRAY

  Type: Error
  File: Data/Temporary/Development/Cache/Code/Flow_Object_Classes/Neos_ContentRepos
        itory_Domain_Service_ImportExport_NodeImportService.php
  Line: 642

[mhsdesign]

Since convertToPHPValue now always returns an array, null will raise an error:

Exception #XXX in line 468 of /Packages/Libraries/doctrine/orm/lib/Doctrine/ORM/Internal/Hydration/AbstractHydrator.php: The JsonArrayType only converts arrays, null given
77 Neos\Flow\Persistence\Doctrine\DataTypes\JsonArrayType::convertToPHPValue(NULL, Doctrine\DBAL\Platforms\PostgreSQL100Platform)
76 Doctrine\ORM\Internal\Hydration\AbstractHydrator::gatherRowData(array|21|, array|1|, array|1|)
75 Doctrine\ORM\Internal\Hydration\ObjectHydrator::hydrateRowData(array|21|, array|0|)
74 Doctrine\ORM\Internal\Hydration\ObjectHydrator::hydrateAllData()

i think it can be tracked down to our nullable json_array_type

/**
 * @ORM\Column(type="flow_json_array",nullable=true)
 * @var array|null
 */
protected ?array $value = [];

fetching the entities from the repository doesnt work anymore with this change. Has anyone else experienced this problem or are we using the api wrong? ^^

[kdambekalns]

Is "our nullable json_array_type" in Neos? Or is "our" code in this case your code?

Anyway, if the implementation of the type did return null before, and it still could do that (e.g. no interface prohibiting that), it could probably be allowed (again), to do so.

[mhsdesign]

No its in a clients code base ;)

So i created a pr and will test the patch in the project now #3135