Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUGFIX: Prevent type hint errors with latest Fluid minor release #3038

Merged
merged 2 commits into from
May 5, 2023

Conversation

Sebobo
Copy link
Member

@Sebobo Sebobo commented May 5, 2023

The 2.8.0 release of Fluid introduced breaking changes (type declarations), thus this changes the dependency to allow only 2.7.x.

Resolves: #3037

Checklist

  • Code follows the PSR-2 coding style
  • Tests have been created, run and adjusted as needed
  • The PR is created against the lowest maintained branch
  • Reviewer - PR Title is brief but complete and starts with FEATURE|TASK|BUGFIX
  • Reviewer - The first section explains the change briefly for change-logs
  • Reviewer - Breaking Changes are marked wit !!! and have upgrade-instructions

@kitsunet
Copy link
Member

kitsunet commented May 5, 2023

Thank you!

@Sebobo Sebobo changed the title BUGFIX: Don’t use latest Fluid minor release BUGFIX: Prevent type hint errors with latest Fluid minor release May 5, 2023
@markusguenther
Copy link
Member

markusguenther commented May 5, 2023

Guess we should upmerge that immediately and release it to prevent more issues.
I can take care.

@crydotsnake crydotsnake linked an issue May 5, 2023 that may be closed by this pull request
1 task
Copy link
Member

@kdambekalns kdambekalns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 A pity that's needed, though…

@markusguenther markusguenther merged commit e41855e into 7.3 May 5, 2023
@markusguenther markusguenther deleted the bugfix/3037-fluid-dependency branch May 5, 2023 08:30
@Sebobo
Copy link
Member Author

Sebobo commented May 5, 2023

Why do we have that dependency in two places?

@kitsunet
Copy link
Member

kitsunet commented May 5, 2023

You mean root of collection and fluidadaptor? For the split packages. Technically only the Adaptor depends on fluid, but composer doesn't understand our collections so for composer if you install the collection we need to mirror all dependencies from all included packages to the top level composer.json, there is a build script to do that automatically, you should normally not change the root collection composer.json by hand.

Build/BuildEssentials/ComposerManifestMerger.php you just call this in the root of the collection.

robertlemke added a commit that referenced this pull request Jun 14, 2024
Flow 8.x only works correctly with typo3fluid 2.7.x - see: #3038, #3041 and #3358
robertlemke added a commit that referenced this pull request Jun 14, 2024
Flow 8.x only works correctly with typo3fluid 2.7.x - see: #3038, #3041 and #3358
neos-bot pushed a commit to neos/flow that referenced this pull request Jun 14, 2024
neos-bot pushed a commit to neos/fluidadaptor that referenced this pull request Jun 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: Fluid 2.8.0 causes type hint errors
5 participants