Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUGFIX: More descriptive reflection error if attribute does not exist #3179

Merged
merged 2 commits into from Feb 5, 2024
Merged

BUGFIX: More descriptive reflection error if attribute does not exist #3179

merged 2 commits into from Feb 5, 2024

Conversation

mhsdesign
Copy link
Member

@mhsdesign mhsdesign commented Sep 25, 2023 •
edited by kitsunet

Adds error catching and more context information if an attribute could not be instantiated.

Resolves: #3178

Upgrade instructions

Review instructions

Checklist

  • Code follows the PSR-2 coding style
  • Tests have been created, run and adjusted as needed
  • The PR is created against the lowest maintained branch
  • Reviewer - PR Title is brief but complete and starts with FEATURE|TASK|BUGFIX
  • Reviewer - The first section explains the change briefly for change-logs
  • Reviewer - Breaking Changes are marked wit !!! and have upgrade-instructions

@mhsdesign mhsdesign linked an issue Sep 25, 2023 that may be closed by this pull request
BUG: Not imported Inject annotation doesnt tell where it was used #3178
Closed
@mhsdesign mhsdesign changed the base branch from 7.3 to 8.3 February 3, 2024 11:48
@github-actions github-actions bot added 8.3 and removed 7.3 labels Feb 3, 2024
@mhsdesign mhsdesign force-pushed the bugfix/3178-reflection-more-descriptive-error-if-annotation-doesnt-exist branch from 3aee4e0 to 84e8538 Compare February 3, 2024 11:51
jonnitto
jonnitto approved these changes Feb 5, 2024
View reviewed changes
Copy link
Member

@jonnitto jonnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine by reading

@kitsunet kitsunet changed the title BUGFIX: 3178 reflection more descriptive error if annotation doesnt e… BUGFIX: More descriptive reflection error if attribute does not exist Feb 5, 2024
@mhsdesign mhsdesign merged commit 7378d60 into 8.3 Feb 5, 2024
12 checks passed
@mhsdesign mhsdesign deleted the bugfix/3178-reflection-more-descriptive-error-if-annotation-doesnt-exist branch February 5, 2024 12:40
@mhsdesign mhsdesign mentioned this pull request Feb 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kitsunet kitsunet kitsunet approved these changes

@jonnitto jonnitto jonnitto approved these changes

Assignees
No one assigned
Labels
8.3 Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BUG: Not imported Inject annotation doesnt tell where it was used
3 participants
@mhsdesign @kitsunet @jonnitto