Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUGFIX: Set neos/flow dependencies to self.version #3191

Closed
wants to merge 1 commit into from

Conversation

c4ll-m3-j4ck
Copy link

Set the package-dependencies to "self.version" to create an installable set of dependencies.

It seems like this upmerge-commit from 8.3 (7982ae5) breaks the installable set of dependencies for the 9.0 branch.

I was able to resolve the dependency-issues by resetting the dependencies to self.version across all flow-development-collection packages.

Copy link
Member

@crydotsnake crydotsnake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! 💙

@crydotsnake crydotsnake changed the title FIX: Set neos/flow dependencies to self.version BUGFIX: Set neos/flow dependencies to self.version Oct 9, 2023
@crydotsnake
Copy link
Member

crydotsnake commented Oct 9, 2023

I didnt saw it at the first place 😅

But this PR is a duplicate of #3185

Regarding issue: #3168

So i will close this then.

But thanks anyway for the contribution ! 💙

@c4ll-m3-j4ck
Copy link
Author

Hey,
didn't see that, thank you for checking it out but sorry for the additional work!

@crydotsnake
Copy link
Member

Hey,

didn't see that, thank you for checking it out but sorry for the additional work!

No problem at all! 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants