Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TASK: Adjust phpstan command to Neos' dev collection #3271

Merged
merged 1 commit into from Jan 24, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 2 additions & 1 deletion .composer.json
Expand Up @@ -8,8 +8,9 @@
"replace": {
},
"scripts": {
"lint:phpstan": "../../bin/phpstan analyse",
"lint": [
"../../bin/phpstan analyse"
"@lint:phpstan"
]
},
"suggest": {
Expand Down
5 changes: 3 additions & 2 deletions Readme.rst
Expand Up @@ -54,6 +54,7 @@ Contributing

If you want to contribute to Flow Framework and want to set up a development environment, then follow these steps:

Clone and install the flow dev distribution https://github.com/neos/flow-development-distribution via git and composer or use this shorthand:
``composer create-project neos/flow-development-distribution flow-development @dev --keep-vcs``

Note the **-distribution** package you create a project from, instead of just checking out this repository.
Expand All @@ -65,8 +66,8 @@ Here you can do all Git-related work (``git add .``, ``git commit``, etc).

Unit tests can be run here via ``../../bin/phpunit -c ../../Build/BuildEssentials/PhpUnit/UnitTests.xml``, functional tests via ``../../bin/phpunit -c ../../Build/BuildEssentials/PhpUnit/FunctionalTests.xml`` and static analysis via ``composer lint``.

To switch the branch you intend to work on:
``git checkout 6.3 && composer update``
To switch the branch you intend to work on run this command in the root of the dev distribution:
``git checkout 8.3 && composer update``

.. note:: We use an upmerging strategy, so create all bugfixes to lowest maintained branch that
contains the issue (typically the second last LTS release, check the diagram on
Expand Down
3 changes: 2 additions & 1 deletion composer.json
Expand Up @@ -64,8 +64,9 @@
"neos/utility-unicode": "self.version"
},
"scripts": {
"lint:phpstan": "../../bin/phpstan analyse",
"lint": [
"../../bin/phpstan analyse"
"@lint:phpstan"
]
},
"suggest": {
Expand Down