BUGFIX: Prevent getPublicStaticResourceUri from crashing in cli con…

[mhsdesign]

…text

Resolves: neos/neos-development-collection#4888

Related: #2157

Currently, if a no absolute baseUri is set the BaseUriProvider::getConfiguredBaseUriOrFallbackToCurrentRequest will throw an exception.

No base URI could be provided. This probably means a call was made outside of an HTTP request and a base
URI was neither configured nor specified as $fallbackRequest.

This makes it nearly* impossible to render resource paths in cli

Upgrade instructions

Review instructions

Checklist

• Code follows the PSR-2 coding style
• Tests have been created, run and adjusted as needed
• The PR is created against the lowest maintained branch
• Reviewer - PR Title is brief but complete and starts with FEATURE|TASK|BUGFIX
• Reviewer - The first section explains the change briefly for change-logs
• Reviewer - Breaking Changes are marked with !!! and have upgrade-instructions

[bwaidelich]

IMO it's a dangerous approach to silently convert the exception since.
Instead we should IMO throw if the absoluteBaseUri is not set and make sure that it is on the "outside"..

Related: #2157

[mhsdesign]

Yes i outlined a possible approach that could work for Flow 9 in #3334 and am willing to close this.

[mhsdesign]

i dont think how we could archive this?

make sure that it (the absoluteBaseUri) is set on the "outside".

the only way to set it is via this 😂

ObjectAccess::setProperty($this->baseUriProvider, "configuredBaseUri", 'http://localhost:8080', true);

thats why i proposed a refactoring in: #3334

but ill close this here, lets continue the discussion over there.

[bwaidelich]

It's an option of the target