FEATURE: Allow PositionalArraySorter to keep null values
#3350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By default, the `PositionalArraySorter` removes all `null` values. This change makes this behavior an _option_ that can be passed to the constructor: ```php (new PositionalArraySorter(['foo' => null]))->toArray(); // [] (new PositionalArraySorter(['foo' => null], removeNullValues: false))->toArray(); // ['foo'] ``` Besides, this cleans up the code and tests
bwaidelich
commented
May 7, 2024
| { | ||
| $arrayKeysWithPosition = []; | ||
|
|
||
| foreach ($this->subject as $key => $value) { | ||
| // if the value was set to NULL it was unset and should not be used | ||
| if ($value === null) { | ||
| if ($value === null && $this->removeNullValues) { |
There was a problem hiding this comment.
I admit that I added some code cleanups with the changes.. I just couldn't stand looking at this ancient coding style..
But trust me: Apart from making this class final and some mostly cosmetic tweaks this line is the only actual change
kitsunet
approved these changes
Jul 3, 2024
|
Good, good, good! |
|
Do we also want start using this now in fusion? neos/neos-development-collection#5033 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default, the
PositionalArraySorterremoves allnullvalues. This change makes this behavior an option that can be passed to the constructor:Besides, this cleans up the code and tests