Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TASK: Clarify positioning of arguments and options in CommandController #379

Merged
merged 1 commit into from Jun 7, 2016

Conversation

lorenzulrich
Copy link
Contributor

In the method signature, all (mandatory) arguments must be placed in front of the options. If not, all options placed in front of the last argument become mandatory, too in the command line prompt. This should be stated explicitely in the documentation.

In the method signature, all (mandatory) arguments must be placed in front of the options. If not, all options placed in front of the last argument become mandatory, too in the command line prompt. This should be stated explicitely in the documentation.
@kitsunet
Copy link
Member

kitsunet commented Jun 7, 2016

IMHO that's a question of best practice and doesn't need to be stated. The PHP docs already say it's best practice to do that for all argument declarations. I would still be ok merging this...

@lorenzulrich
Copy link
Contributor Author

I would prefer to merge it for the following reason: If not following best practise, the command line states Please specify the required argument "foo": which is not correct.

@albe
Copy link
Member

albe commented Jun 7, 2016

True that it is a rather generic thing to know about php specifics, but then OTOH the little additional sentence doesn't hurt in the documentation. So 👍 from me

@kitsunet kitsunet merged commit 69cc668 into neos:2.3 Jun 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants