BUGFIX: Type Handling should not break when classnames contain underscores, or when classnames are lowerCamelCase #441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cores While underscores in class names are not used in Flow code itself, it might happen that TypeHandling is used outside Flow - where having underscores in class names is perfectly valid. This change ensures that underscores in class names are recognized properly.
|
@skurfuerst, thanks for your PR! By analyzing the annotation information on this pull request, we identified @kdambekalns, @robertlemke and @kitsunet to be potential reviewers |
|
Nice! I think together with #437 we should have tackled everyhing :) |
The TypeHandling PARSE_TYPE_PATTERN assumes vendors in namespace do always begin with uppercase letters. Reality shows, that this is not the case. So this changes the regular expression accordingly.
skurfuerst
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While underscores in class names are not used in Flow code itself, it might
happen that TypeHandling is used outside Flow - where having underscores
in class names is perfectly valid.
This change ensures that underscores in class names are recognized properly.