BUGFIX: Doctrine controller should allow empty host for database #442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The doctrine controller checked for correct configuration of a database before calling the doctrine methods. As the drivers all have different options the ``host`` is a not a conclusive check. The only thing that can be checked is if a driver was set.
|
@kitsunet, thanks for your PR! By analyzing the annotation information on this pull request, we identified @kdambekalns, @dfeyer and @robertlemke to be potential reviewers |
|
@robertlemke @kdambekalns This should fix the configuration problem regarding sockets and/or no host. IMHO that makes much more sense for now. Please quickly check. Behavior is as expected. |
|
What happens when no host is configured, though? Does some default come from us, Doctrine or even MySQL itself? |
|
@kdambekalns yes the EntityManagerFactory currently defaults that to 127.0.0.1 as was before via settings |
|
I see. Well, I like. :) |
| @@ -499,4 +485,14 @@ protected function handleException(\Exception $exception) | |||
| $this->systemLogger->logException($exception); | |||
| $this->quit(1); | |||
| } | |||
|
|
|||
| protected function isDatabaseConfigured() | |||
|
Tests pass, will merge for now :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The doctrine controller checked for correct configuration of a database
before calling the doctrine methods. As the drivers all have different
options the
hostis a not a conclusive check. The only thing thatcan be checked is if a driver was set.