BUGFIX: Port is set correctly when Trusted Proxy only sends protocol override #493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…override Before the port of the request URI would not be correctly set if the Trusted Proxy would send an `X-Forwarded-Proto: HTTPS` header without also specifying a forwarded port. This resulted in generated URLs like "https://acme.com:80". The change fixes that by doing a case insensitive check for the protocol to be 'https' and set port 443 accordingly.
| @@ -440,6 +440,12 @@ public function forwardHeaderTestsDataProvider() | |||
| 'requestUri' => 'https://acme.com', | |||
| 'expectedUri' => 'https://acme.com:80', | |||
| ), | |||
| array( | |||
There was a problem hiding this comment.
Small nitpick: Use short array syntax.
There was a problem hiding this comment.
Not if the other declarations use the long form. And since it's better not to mix functional and cleanup, let's leave it like that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before the port of the request URI was not set correctly if the Trusted Proxy would
send an
X-Forwarded-Proto: HTTPSheader without also specifying a forwarded port.This resulted in generated URLs like "https://acme.com:80".
The change fixes that by doing a case insensitive check for the protocol to be
'https' and set port 443 accordingly.