BUGFIX: Doctrine DataTypes should not be proxied #645
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since 3.3 the doctrine types often ended up being proxied, due to a change in proxy generation on aspected parent classes. This would throw an exception because the DBAL\Types base classes constructor is private and hence cannot be called from the proxied constructor. This works around that issue by making sure the custom DBAL Types are not proxied. Fixes neos#516
|
@albe, thanks for your PR! By analyzing the annotation information on this pull request, we identified @radmiraal, @kdambekalns and @daniellienert to be potential reviewers |
svparijs
approved these changes
Sep 29, 2016
|
Just a symptom fix but lets have it for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since 3.3 the doctrine types often ended up being proxied, due to a change in proxy generation
on aspected parent classes. This would throw an exception because the DBAL\Types base classes
constructor is private and hence cannot be called from the proxied constructor.
This works around that issue by making sure the custom DBAL Types are not proxied.
Fixes #516