Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TASK: Remove TYPO3 occurrences in docs and tests #839

Merged

Conversation

robertlemke
Copy link
Member

This change removes some further TYPO3 occurrences and replaces
them by Neos.

Relates to #823

This change removes some further TYPO3 occurrences and replaces
them by Neos.

Relates to neos#823
@mention-bot
Copy link

@robertlemke, thanks for your PR! By analyzing the history of the files in this pull request, we identified @bwaidelich, @kdambekalns and @kitsunet to be potential reviewers.

Copy link
Member

@kdambekalns kdambekalns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@@ -37,7 +37,7 @@ public function configuredFiltersAreCreatedCorrectlyUsingLegacySettingsFormat()

if ($args[0] === 'URI') {
return 'mockPatternURI';
} elseif ($args[0] === 'TYPO3\\TestRequestPattern') {
} elseif ($args[0] === 'Neos\\TestRequestPattern') {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The name of that test contains UsingLegacySettingsFormat - is that needed still? Also, it fails, so maybe there is a settings that needs to be adjusted (Testing context!?)

@robertlemke robertlemke merged commit f42a124 into neos:4.0 Jan 27, 2017
@robertlemke robertlemke deleted the task/remove-typo3-occurrences-in-docs branch January 27, 2017 07:30
@robertlemke robertlemke moved this from Needs review to Done in Neos 3.0 & Flow 4.0 Release Board Jan 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

4 participants