TASK: #899 Make Fizzle filter nested object properties #924
Conversation
|
@joachimmathes, thanks for your PR! By analyzing the history of the files in this pull request, we identified @robertlemke, @skurfuerst and @gerhard-boden to be potential reviewers. |
| @@ -12,7 +12,7 @@ namespace Neos\Eel; | |||
| * source code. | |||
| */ | |||
|
|
|||
| require_once __DIR__ . '/../../../Resources/Private/PHP/php-peg/Parser.php'; | |||
| require_once __DIR__ . '/../Resources/Private/PHP/php-peg/Parser.php'; | |||
There was a problem hiding this comment.
Is this really correct? Not rather '/../PHP/php-peg/Parser.php'?
There was a problem hiding this comment.
Thank you! :)
And thanks for pointing this out. When I generated AbstractParser.php from AbstractParser.peg.inc for the first time, i.e. with /../../../Resources ..., the Unit-Tests didn't run at all due to the wrong path. So I changed it to /../Resources/ ..., since the resulting AbstractParser.php is placed in Classes/. That's why I'm pretty sure this is correct. And not only the Unit-Tests have worked as expected by then, but also the respective line in AbstractParser.php hasn't changed in the diff.
There was a problem hiding this comment.
Hm, must be a misconception on my side and I guess I have a clue on what it is (this just being the code template for the actual AbstractParser, which resides somewhere else and not being actually executed itself)... well, no objections from my side then :)
| @@ -12,7 +12,7 @@ namespace Neos\Eel; | |||
| * source code. | |||
| */ | |||
|
|
|||
| require_once __DIR__ . '/../../../Resources/Private/PHP/php-peg/Parser.php'; | |||
| require_once __DIR__ . '/../Resources/Private/PHP/php-peg/Parser.php'; | |||
There was a problem hiding this comment.
Hm, must be a misconception on my side and I guess I have a clue on what it is (this just being the code template for the actual AbstractParser, which resides somewhere else and not being actually executed itself)... well, no objections from my side then :)
|
The final parsers are created from the |
There was a problem hiding this comment.
Looks good by reading and running the tests. Thx for the PR ;)
But we need an accompanying change to update the usage of 'Identifer' in Neos.ContentRepository/Classes/Eel/FlowQueryOperations/ChildrenOperation.php:106 or we put an additional entry Identifier in the parsed result object to stay compatible (also with user operations). I'd tend to the latter one because it would not be breaking which the change would be otherwise for 3rd party operations.
|
Lesson learned: Always check the NEOS development package when changing fundamental code in the Flow development package. :) |
What I did
Implements #899. I extended the FlowQuery grammar to filter nested object properties.
How I did it
It was not possible to just extend the
Identifierrule inAbstractParser.peg.incsince that led to a lot of regressions in the Eel parser. Thus, a new rulePropertyPathwas necessary.How to verify it
Unit-Tests in Neos.Eel run successfully.