Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return type of getUploadedImage() too strict? #119

Closed
kdambekalns opened this issue Jul 23, 2020 · 1 comment
Closed

Return type of getUploadedImage() too strict? #119

kdambekalns opened this issue Jul 23, 2020 · 1 comment
Assignees
Labels

Comments

@kdambekalns
Copy link
Member

In a project I ran into this problem:

Return value of Neos\Form\ViewHelpers\Form\UploadedImageViewHelper_Original::getUploadedImage() must be an instance of Neos\Media\Domain\Model\Image or null, instance of Neos\Flow\Persistence\Doctrine\Proxies\__CG__\Neos\Media\Domain\Model\ImageVariant returned

Similar to #118, see #111

@kdambekalns kdambekalns self-assigned this Jul 23, 2020
@kdambekalns
Copy link
Member Author

Looking at

return $this->propertyMapper->convert($this->getValueAttribute(), Image::class);
that should create an Image in all cases, no?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants