Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Render id={form.identifier} around ConfirmationFinisher #130

Closed
paavo opened this issue Jan 5, 2021 · 0 comments
Closed

Render id={form.identifier} around ConfirmationFinisher #130

paavo opened this issue Jan 5, 2021 · 0 comments

Comments

@paavo
Copy link

paavo commented Jan 5, 2021

The <form> is rendered always withid={form.identifier}
After submitting the Form #{form.identifier} will be added to the URL.
If the Form is somewhere on the Page, the anchor #{form.identifier} will jump to the Form.

The Neos.Form.Builder:ConfirmationFinisher does NOT render id={form.identifier} around.
Because of the missing id, the Browser doesn't jump to the Confirmation Message and it maybe get lost somewhere on the page.

What about wrapping an id={form.identifier} around the Builder:ConfirmationFinisher?

I created a PR to fix this: #129

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants